-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparse_serial timeout issues in some nightly builds, PR testing #1918
Comments
These tests seem to be the most expensive additions:
Prior to merge #1740, only
|
After PR #1922, these tests take a total of 10s on my laptop (almost 700s above). If 1922 does not resolve it I can look further. |
Thanks @cwpearson , your PR helped improve the test time and get past the bsr_spmmv tests. |
I also found some timeouts on the The biggest offenders I've seen are these:
And from a different run
Interestingly, it's not always the same tests which take a long time. For example in 568 that openmp test above only takes a couple seconds |
In the cuda/11.2.2+gcc/8.3.0 debug+boundscheck nightly build on Weaver, these sub-tests of
|
Since the long-running tests are inconsistent among machines/arches, we should consider splitting the sparse unit test apart into separate executables |
To quickly address current CI timeouts we decided in the meeting that
|
The
sparse_serial
unit test duration is exceeding the default 1500 sec duration in some builds, for example in nightly builds with debugging and boundschecking enabled, and also occurred with PR testing e.g. #1916 (comment)This began occurring after merge of these commits:
ODE: changing layout of temp mem in RK algorithms (detail)
ODE: fix unnecessary test overload (detail)
Improve performance of the native BsrMatrix SpMV, especially for single-vector cases. (detail)
hinting that the additional tests in #1740 may need to be adjusted to reduce test time, @cwpearson can you look into adjusting parameters of the added bsr tests to reduce test time while maintaining appropriate coverage?
Reproducer (Weaver, rhel8 queue):
The text was updated successfully, but these errors were encountered: