Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS #756

Open
srajama1 opened this issue Jul 1, 2020 · 6 comments
Open

Remove CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS #756

srajama1 opened this issue Jul 1, 2020 · 6 comments

Comments

@srajama1
Copy link
Contributor

srajama1 commented Jul 1, 2020

@jjwilke : After the ETI files are automatically generated, I don't think we run into this issue of long file names anymore. If yes, can we remove asking users to enable CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS ?

@jjwilke
Copy link
Contributor

jjwilke commented Jul 1, 2020

I'm struggling to reproduce this with the old build. I suspect there should be no problems since link lines are now hundreds of times shorter - but am a bit worried about taking it out unless I can reproduce the old issue.

@srajama1
Copy link
Contributor Author

srajama1 commented Jul 1, 2020

I never reproduced the old issue. It was in windows, mac or ubuntu. There was a PR in Kokkos Kernels to change filenames by an external collaborator to change file names. @ndellingwood : Do you have any thoughts. I am thinking with the shorter file names this option is not needed, but I don't build on windows, mac or ubuntu. The reason for removal is this warned a Trilinos user he needs to set it and that ended up with some weird interaction with Clang. I will post that Trilinos issue link.

@srajama1
Copy link
Contributor Author

srajama1 commented Jul 1, 2020

trilinos/Trilinos#7035

@jjwilke
Copy link
Contributor

jjwilke commented Jul 2, 2020

Hmm. I guess we can go ahead and remove the warning and see what happens. I'm 99.99% sure we won't ever need response files anymore.

@srajama1
Copy link
Contributor Author

srajama1 commented Jul 2, 2020

That is what I am thinking too. This was a workaround suggested by Trilinos framework team to avoid having compile errors with long file names (and lots of them).

@fontanj
Copy link

fontanj commented May 14, 2022

Hi guys,

I'm trying to build Trilinos version 13.2.0 (including Kokkos), and I am indeed running into "Argument list too long" errors, because there are so many "-I" include directories in the compile command. I tried using the CMAKE_CXX_USE_RESPONSE_FILES_FOR_INCLUDES options as it says here:

But it didn't seem to work. I got the same error and still have the long list of "-I" includes in the commands. So I came across this thread as I'm trying to figure out why it didn't work. Was this option removed? Or is it just a warning that was removed?

Thanks,
Josh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants