-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS #756
Comments
I'm struggling to reproduce this with the old build. I suspect there should be no problems since link lines are now hundreds of times shorter - but am a bit worried about taking it out unless I can reproduce the old issue. |
I never reproduced the old issue. It was in windows, mac or ubuntu. There was a PR in Kokkos Kernels to change filenames by an external collaborator to change file names. @ndellingwood : Do you have any thoughts. I am thinking with the shorter file names this option is not needed, but I don't build on windows, mac or ubuntu. The reason for removal is this warned a Trilinos user he needs to set it and that ended up with some weird interaction with Clang. I will post that Trilinos issue link. |
Hmm. I guess we can go ahead and remove the warning and see what happens. I'm 99.99% sure we won't ever need response files anymore. |
That is what I am thinking too. This was a workaround suggested by Trilinos framework team to avoid having compile errors with long file names (and lots of them). |
@jjwilke : After the ETI files are automatically generated, I don't think we run into this issue of long file names anymore. If yes, can we remove asking users to enable CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS ?
The text was updated successfully, but these errors were encountered: