ROCm: Performance tests not building

[chipfreitag]

Fails building PerfTest_CustomReduction.cpp.

/home/chipf/kokkos/core/perf_test/PerfTest_CustomReduction.cpp:66:7: error: no
matching function for call to 'parallel_reduce'
Kokkos::parallel_reduce(Kokkos::ThreadVectorRange(team,32), [&] (c...
plus much more.
I think the constructor at :
/home/chipf/kokkos/core/src/ROCm/Kokkos_ROCm_Parallel.hpp:1133:6: note:
candidate function [with iType = int, Lambda = (lambda at
/home/chipf/kokkos/core/perf_test/PerfTest_CustomReduction.cpp:66:67),
ValueType = Kokkos::Experimental::Max<double, Kokkos::HostSpace>] not
viable: expects an l-value for 3rd argument
void parallel_reduce(const Impl::ThreadVectorRangeBoundariesStruct<iType...
should be the right one, but the compiler disagrees.

[chipfreitag]

Issue reported to ROCm tools team

[chipfreitag]

Further analysis shows this was not a compiler issue. The CustomReduction tests call parallel_reduce with a reducer instead of a value. That case was not implemented, but has been added in the issue branch.
The performance test case now builds and runs, but not confident of the coverage this provides.
Will be looking at unit tests to see which ones provide coverage.