-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: should StaticCrsGraph have a row() method? #1071
Comments
Book-keeping: this was implemented in #1072 which was merged. Waiting on a unit test too, but already technically in develop. |
Could somebody assign this to me so that I won't forget? |
done :) |
I opened a new issue for the UnitTest since this will be closed with the next promotion. Andrey can you comment in there with just a "I am here" or so so I can assign it to you? |
@crtrott Go ahead and assign it to me. And then close this one, as the new one supersedes it. |
And this one will be closed with the next promotion to master. At each promotion all "InDevelop" issues will be closed. |
Is it OK to add a commit that pushes the feature to the current Trilinos until the next Kokkos snapshot? |
@aprokop the next snapshot is supposedly happening soon. Probably sometime next week? |
@ibaned Thanks, I can wait then. |
I'm thinking that in some situations it would be convenient to have a
row()
method similarly toKokkosSparse::CrsMatrix
except missing values. It should also bypass manual attempts like creating subviews. I would be willing to implement this if agreed upon.The text was updated successfully, but these errors were encountered: