Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: should StaticCrsGraph have a row() method? #1071

Closed
aprokop opened this issue Sep 3, 2017 · 10 comments
Closed

Question: should StaticCrsGraph have a row() method? #1071

aprokop opened this issue Sep 3, 2017 · 10 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@aprokop
Copy link
Collaborator

aprokop commented Sep 3, 2017

I'm thinking that in some situations it would be convenient to have a row() method similarly to KokkosSparse::CrsMatrix except missing values. It should also bypass manual attempts like creating subviews. I would be willing to implement this if agreed upon.

@aprokop aprokop changed the title Question: should StaticCrsGraph have a row() method Question: should StaticCrsGraph have a row() method? Sep 3, 2017
@ibaned
Copy link
Contributor

ibaned commented Sep 5, 2017

Book-keeping: this was implemented in #1072 which was merged. Waiting on a unit test too, but already technically in develop.

@ibaned ibaned added the Enhancement Improve existing capability; will potentially require voting label Sep 5, 2017
@ibaned ibaned added this to the 2017-September (mid) milestone Sep 5, 2017
@aprokop
Copy link
Collaborator Author

aprokop commented Sep 5, 2017

Could somebody assign this to me so that I won't forget?

@ibaned
Copy link
Contributor

ibaned commented Sep 5, 2017

done :)

@crtrott
Copy link
Member

crtrott commented Sep 5, 2017

I opened a new issue for the UnitTest since this will be closed with the next promotion. Andrey can you comment in there with just a "I am here" or so so I can assign it to you?

@aprokop
Copy link
Collaborator Author

aprokop commented Sep 5, 2017

@crtrott Go ahead and assign it to me. And then close this one, as the new one supersedes it.

@ibaned
Copy link
Contributor

ibaned commented Sep 5, 2017

@aprokop since you're not officially a Kokkos dev you have to post a comment on #1076 before he can assign it to you

@crtrott
Copy link
Member

crtrott commented Sep 5, 2017

And this one will be closed with the next promotion to master. At each promotion all "InDevelop" issues will be closed.

@aprokop
Copy link
Collaborator Author

aprokop commented Sep 8, 2017

Is it OK to add a commit that pushes the feature to the current Trilinos until the next Kokkos snapshot?

@ibaned
Copy link
Contributor

ibaned commented Sep 8, 2017

@aprokop the next snapshot is supposedly happening soon. Probably sometime next week?

@aprokop
Copy link
Collaborator Author

aprokop commented Sep 8, 2017

@ibaned Thanks, I can wait then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

3 participants