Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uintptr_t for casting pointers #110

Closed
ndellingwood opened this issue Oct 14, 2015 · 4 comments
Closed

Use uintptr_t for casting pointers #110

ndellingwood opened this issue Oct 14, 2015 · 4 comments

Comments

@ndellingwood
Copy link
Contributor

KokkosExp_SharedAlloc.hpp - fix this (unsigned long)

@nmhamster
Copy link
Contributor

Can you describe the error/bug for this issue?

@hcedwar
Copy link
Contributor

hcedwar commented Oct 14, 2015

With the exception of Windows every compiler has sizeof(void*) == sizeof(unsigned long).
For portability all casts between pointer and integer types should use the C99 'uintptr_t' integer type, which the C99 language standard states must match size.

@crtrott
Copy link
Member

crtrott commented Oct 29, 2015

Isn't that fixed now on Develop?

@ndellingwood
Copy link
Contributor Author

Yes, I amended a previous commit to fix formatting issues on Clang compiler.
I'll close the issue (if I'm able), I'm still getting acquainted to using GitHub sorry for any workflow mistakes.

In case extra info is necessary to check:
The amended commit was submitted for pull request on Oct 16, sha 467fb78
It was merged Oct 19 as request #116, sha 6e3081a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants