Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Disable Initialize Warnings #1142

Closed
jrood-nrel opened this issue Oct 4, 2017 · 6 comments
Closed

Option to Disable Initialize Warnings #1142

jrood-nrel opened this issue Oct 4, 2017 · 6 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@jrood-nrel
Copy link

jrood-nrel commented Oct 4, 2017

I see one other issue about this involving CUDA warnings, and looking at the code, I don't see any way to disable warnings, but in general I think we need an option to be able to turn off Kokkos warnings in which we can't set something like OMP_PROC_BIND to alleviate. I understand that I may be (probably am) naive in running with the wrong configuration, but the main reason I have for this is that I run tests on a two core machine with mpirun -np 8, etc, and I'm very aware the processor is oversubscribed, but the warning*8 really gets in the way of the test output.

@ibaned ibaned added this to the 2017 October milestone Oct 4, 2017
@ibaned ibaned added the Enhancement Improve existing capability; will potentially require voting label Oct 4, 2017
@ibaned
Copy link
Contributor

ibaned commented Oct 4, 2017

One of the many things going in with the merge to satisfy #255 will be much nicer options to control Kokkos warnings. I believe there will be three options: (1) print on all ranks, (2) print only on MPI rank 0, (3) don't print at all. @dsunder can correct me on this.

Sorry for the delay on this, but its bundled with a wholesale refactor of the pthread->std::thread backend which understandably required much code review, regression fixing, and performance testing.

@ibaned
Copy link
Contributor

ibaned commented Oct 25, 2017

This also addresses #1060

@jrood-nrel
Copy link
Author

Thanks. Since we use Kokkos through Trilinos, we will probably also have to wait for this to propagate through Trilinos I assume. However, I will close this issue since it seems to have been directly addressed now.

@ibaned
Copy link
Contributor

ibaned commented Oct 25, 2017

@jrood-nrel, we actually have a policy not to close issues until the fix propagates to Trilinos, so I'll reopen this, and once its closed again that will indicate that the fix is in the Trilinos develop branch.

@dholladay00
Copy link

If I wanted to do this at initialization, could I do that with Kokkos::initialize(Kokkos::InitArguments(dw=true));? I haven't updated to latest master, but when I do, I plan on doing this (or whatever the correct way to do it). Also, did the fix PR include a way to have the warnings printed only from rank 0 if running with MPI?

@ibaned
Copy link
Contributor

ibaned commented Nov 17, 2017

@dholladay00 I think the rank 0 only feature is still coming up. Both questions are best answered by @dsunder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

5 participants