Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize can fail with Cuda due to asynchronous dispatch #119

Closed
crtrott opened this issue Oct 29, 2015 · 1 comment
Closed

Resize can fail with Cuda due to asynchronous dispatch #119

crtrott opened this issue Oct 29, 2015 · 1 comment
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@crtrott
Copy link
Member

crtrott commented Oct 29, 2015

The Kokkos::resize function was starting a copy function (remap) and then immediately assigning the new view to the old. If the view given to resize had a reference count of one, and one was not forcing Cuda to block its dispatch (i.e. because you are using UVM), then this function could deallocate the original view while the copy kernel is still running.

This is now fixed in develop.
@crtrott crtrott added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) bug - fix pushed to develop branch labels Oct 29, 2015
@crtrott
Copy link
Member Author

crtrott commented Nov 12, 2015

Pushed to master

@crtrott crtrott closed this as completed Nov 12, 2015
@crtrott crtrott self-assigned this Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crtrott