Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokkos::complex: Need op* w/ std::complex & real #126

Closed
mhoemmen opened this issue Nov 10, 2015 · 2 comments
Closed

Kokkos::complex: Need op* w/ std::complex & real #126

mhoemmen opened this issue Nov 10, 2015 · 2 comments

Comments

@mhoemmen
Copy link
Contributor

Kokkos::complex needs the following two nonmember functions:

template<class RealType>
Kokkos::complex<RealType> 
operator* (const std::complex<RealType>&, const Kokkos::complex<RealType>&);

template<class RealType>
Kokkos::complex<RealType> 
operator* (const RealType&, const Kokkos::complex<RealType>&);

Note that they are NOT marked KOKKOS_INLINE_FUNCTION; they cannot be, because std::complex's methods lack the necessary device markings for CUDA.

@mhoemmen
Copy link
Contributor Author

Unfortunately Github does not let me attach patch files. I will have to refer y'all to the following Trilinos commits:

commit fbced750853e0d51c32702219ec535c293a66f3c
Author: Mark Hoemmen mhoemme@sandia.gov
Date: Mon Nov 9 14:19:08 2015 -0700

Kokkos{Core,Containers}: Add operator*(std::complex,Kokkos::complex)

commit da42b3e113706b9e4e3b89feaf8e794d55b2f0bd
Author: Mark Hoemmen mhoemme@sandia.gov
Date: Mon Nov 9 15:00:43 2015 -0700

KokkosCore: Add missing Kokkos::complex<T> op*(T, Kokkos::complex<T>)

@mhoemmen
Copy link
Contributor Author

I just submitted a pull request (#127) for this, so I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant