View constructor should check arguments

[ibaned]

The following code compiles and runs with no errors or warnings at all.

Kokkos::View<int> my_view("foo", 100);
std::cout << my_view.extent(0) << '\n'; // prints 1

Our constructors should check for extra arguments that go beyond the rank of the view.

@csiefer2

[stanmoore1]

Yeah, I got bit by this before when I forgot a * in the type.

[ibaned]

Unfortunately, this is made difficult by the whole "dimensions greater than rank have extent 1 business", see #1263 and #1036.

[ibaned]

Remaining piece: constructor should check argument count

[stanmoore1]

Just one more data point: I switched some one-dimensional views to two dimensions, but forgot to add an additional argument to constructor. The code compiled without errors and I had to debug at runtime--not a good user experience.

[ibaned]

@stanmoore1 this will definitely be fixed in the February Kokkos release.

[stanmoore1]

@ibaned awesome, thanks!