Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOKKOS_ENABLE_DEPRECATED_CODE #1359

Closed
ibaned opened this issue Jan 24, 2018 · 2 comments
Closed

KOKKOS_ENABLE_DEPRECATED_CODE #1359

ibaned opened this issue Jan 24, 2018 · 2 comments
Assignees
@ibaned
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
2018 February

Comments

@ibaned
Copy link
Contributor

ibaned commented Jan 24, 2018 •
edited by crtrott

!defined(KOKKOS_DISABLE_DEPRECATED) -> defined(KOKKOS_ENABLE_DEPRECATED_CODE)

defined(KOKKOS_ENABLE_DEPRECATED_CODE_REMOVAL) -> !defined(KOKKOS_ENABLE_DEPRECATED_CODE)

Makefile option: disable_deprecated_code.
CMake option: Kokkos_ENABLE_Deprecated_Code/KOKKOS_ENABLE_DEPRECATED_CODE.
@ibaned ibaned added the Blocks Promotion Overview issue for release-blocking bugs label Jan 24, 2018
@ibaned ibaned added this to the 2018 February milestone Jan 24, 2018
@ibaned ibaned self-assigned this Jan 24, 2018
@ibaned ibaned mentioned this issue Jan 25, 2018
Merged
@crtrott crtrott added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) bug - fix pushed to develop branch and removed Blocks Promotion Overview issue for release-blocking bugs labels Jan 25, 2018
@mhoemmen
Copy link
Contributor

@rrdrake @prwolfe

@ibaned
Copy link
Contributor Author

ibaned commented Jan 29, 2018

We strongly recommend turning this on as soon you get the latest version of Kokkos so that you can find out all the places you're using deprecated functionality and prepare for its eventual disappearance in Kokkos version 3.0

@ndellingwood ndellingwood mentioned this issue Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibaned ibaned

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
2018 February
Development

No branches or pull requests
4 participants
@mhoemmen @ibaned @crtrott @ndellingwood