-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize Macro names #150
Comments
I like that. Trilinos could also use a similar refactoring of macros. |
The first step is to look over all code and do a survey of all the macro names and how they are used. |
Keep Mark Hoemmen in the loop |
The following patterns have been used to harmonize the macros KOKKOS_HAVE_DEBUG -> KOKKOS_DEBUG KOKKOS_HAVE_XXX -> KOKKOS_ENABLE_XXX all impl macros have been renamed to |
don't forget to fix the CMake autogenerated header file :) |
We are currently using a mixture of
KOKKOS_USE_....
KOKKOS_USING_....
KOKKOS_ENABLE_....
KOKKOS_HAVE_....
We should harmonize this. My current thinking is to harmonize around two variants:
KOKKOS_HAVE_ for capabilities which are available (such as KOKKOS_HAVE_OPENMP etc)
and
KOKKOS_ENABLE_[CATEGORY]_[FEATURE]
for features which are user defined settings to change behavior of Kokkos:
For example:
KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK
KOKKOS_ENABLE_CUDA_DEFAULT_UVM
Thoughts?
The text was updated successfully, but these errors were encountered: