Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize Macro names #150

Closed
crtrott opened this issue Dec 2, 2015 · 5 comments
Closed

Harmonize Macro names #150

crtrott opened this issue Dec 2, 2015 · 5 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@crtrott
Copy link
Member

crtrott commented Dec 2, 2015

We are currently using a mixture of
KOKKOS_USE_....
KOKKOS_USING_....
KOKKOS_ENABLE_....
KOKKOS_HAVE_....

We should harmonize this. My current thinking is to harmonize around two variants:

KOKKOS_HAVE_ for capabilities which are available (such as KOKKOS_HAVE_OPENMP etc)
and
KOKKOS_ENABLE_[CATEGORY]_[FEATURE]
for features which are user defined settings to change behavior of Kokkos:

For example:
KOKKOS_ENABLE_DEBUG_BOUNDS_CHECK
KOKKOS_ENABLE_CUDA_DEFAULT_UVM

Thoughts?

@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Dec 2, 2015
@crtrott crtrott added this to the Backlog milestone Dec 2, 2015
@mhoemmen
Copy link
Contributor

mhoemmen commented Dec 2, 2015

I like that. Trilinos could also use a similar refactoring of macros.

@crtrott crtrott modified the milestones: Summer CleanUP, Backlog Jan 26, 2016
@gmackey
Copy link
Contributor

gmackey commented Jun 15, 2016

The first step is to look over all code and do a survey of all the macro names and how they are used.

@hcedwar
Copy link
Contributor

hcedwar commented Jul 20, 2016

Keep Mark Hoemmen in the loop

@hcedwar hcedwar modified the milestones: Fall 2016, Summer 2016 Aug 31, 2016
@dsunder dsunder assigned dsunder and unassigned gmackey Sep 28, 2016
@hcedwar hcedwar modified the milestones: END 2016, Fall 2016 Nov 1, 2016
@hcedwar hcedwar modified the milestones: 2016-January, END 2016 Jan 3, 2017
@dsunder
Copy link
Contributor

dsunder commented Jan 25, 2017

The following patterns have been used to harmonize the macros

KOKKOS_HAVE_DEBUG -> KOKKOS_DEBUG

KOKKOS_HAVE_XXX -> KOKKOS_ENABLE_XXX
KOKKOS_USE_XXX -> KOKKOS_ENABLE_XXX

all impl macros have been renamed to
KOKKOS_XXX -> KOKKOS_IMPL_XXX

@mhoemmen
Copy link
Contributor

don't forget to fix the CMake autogenerated header file :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

5 participants