Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ExecSpace::initialize / ExecSpace::finalize #1532

Closed
crtrott opened this issue Apr 4, 2018 · 2 comments
Closed

Deprecate ExecSpace::initialize / ExecSpace::finalize #1532

crtrott opened this issue Apr 4, 2018 · 2 comments
Assignees
@ibaned
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2018 April

Comments

@crtrott
Copy link
Member

crtrott commented Apr 4, 2018

Rename them to ExecSpace::impl_initialize etc. Users are only supposed to call Kokkos::initialize from now on.
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Apr 4, 2018
@crtrott crtrott added this to the 2018 April milestone Apr 4, 2018
@crtrott crtrott assigned crtrott and dalabre and unassigned crtrott Apr 4, 2018
@ibaned ibaned assigned ibaned and unassigned dalabre Apr 11, 2018
@ibaned
Copy link
Contributor

ibaned commented Apr 11, 2018

I just did this in a branch

@ibaned
Copy link
Contributor

ibaned commented Apr 12, 2018

Addressed by merged pull request #1553

@ndellingwood ndellingwood mentioned this issue May 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibaned ibaned

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2018 April
Development

No branches or pull requests
4 participants
@ibaned @dalabre @crtrott @ndellingwood