Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicView - remove restrictions to std::is_trivial types and value_type is power of two #1586

Closed
ndellingwood opened this issue Apr 25, 2018 · 2 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@ndellingwood
Copy link
Contributor

@bathmatt needs these restrictions lifted for his application.

Referencing past issue #690 where some discussion occurred regarding performance before changing the implementation of the DynamicView to remove use of the MemoryPool and requiring the max number of blocks to be fixed.

In that issue, @bathmatt was using trivial types and able to work within this restriction, but now requires ability to use the DynamicView with non-trivial types. Since the resize method resize_serial can only be called outside of a parallel region, the past discussion about needing to set a lock around the resize should no longer be a concern.

@ndellingwood ndellingwood added Enhancement Improve existing capability; will potentially require voting Blocks Promotion Overview issue for release-blocking bugs labels Apr 25, 2018
@ndellingwood ndellingwood added this to the 2018 April milestone Apr 25, 2018
@ndellingwood ndellingwood self-assigned this Apr 25, 2018
@ndellingwood
Copy link
Contributor Author

@bathmatt - I checked with @ibaned and @dsunder about lifting the std::is_trival check. Doing so can cause problems depending on why the object is not trivially copyable. We can lift the restriction, but with documented assumption that the type is trivially copyable, and if not than the use will be somewhat at your own risk. Could you provide the struct or type that does not pass this check?

@ndellingwood
Copy link
Contributor Author

PR #1592 issued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

1 participant