Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Assignment: LayoutStride -> LayoutLeft and LayoutStride -> LayoutRight #1594

Closed
crtrott opened this issue Apr 26, 2018 · 5 comments
Closed
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@crtrott
Copy link
Member

crtrott commented Apr 26, 2018

Make this assignable with runtime error checking. @AndrewGaspar

@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Apr 26, 2018
@crtrott crtrott added this to the 2018 June milestone Apr 26, 2018
@AndrewGaspar
Copy link
Contributor

It would also be nice to have built-in routines for checking if a LayoutStride is compatible with LayoutRight so you don't have to check the strides yourself.

@crtrott
Copy link
Member Author

crtrott commented Apr 26, 2018

Something like this?

template<class ViewTypeA, class ViewTypeB>
bool is_assignable(const ViewTypeA& a, const VIewTypeB& b);

@crtrott
Copy link
Member Author

crtrott commented Apr 26, 2018

Btw. if you feel you have time to do something about this let me know ;-).
The place for this is basically found in:
core/src/impl/Kokkos_ViewMapping.hpp

@AndrewGaspar
Copy link
Contributor

AndrewGaspar commented Apr 26, 2018

Yeah, I think I more or less understand the code. I may be able to come up with a fix. The open source policy here at LANL is weird, so it may be easier if I just do it on my own time. But it would probably be useful, anyway, to just submit the approval request to contribute to Kokkos.

@crtrott
Copy link
Member Author

crtrott commented Apr 26, 2018

It might be worthwhile for us to figure out what the policy is with respect to contributing to Kokkos etc. from LANL. From our side we know what all the rules are (for example around auto testing etc.) and we can basically treat you guys as if you were at Sandia. I might talk to Galen and see if we can get guidance on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

3 participants