Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Kokkos_Sort.hpp - BinOp3D - wrong comparison #1720

Closed
pkestene opened this issue Jul 27, 2018 · 1 comment
Closed

Typo in Kokkos_Sort.hpp - BinOp3D - wrong comparison #1720

pkestene opened this issue Jul 27, 2018 · 1 comment
Assignees
@ndellingwood
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
2018 July

Comments

@pkestene
Copy link
Contributor

Hello,

there is a small typo in Kokkos_Sort.hpp, operator() of struct BinOp3D:

keys(i1,1)==keys(i2,2) --> keys(i1,1)==keys(i2,1)

see PR #1718
@ibaned ibaned added this to the 2018 July milestone Aug 1, 2018
@ibaned ibaned added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Aug 1, 2018
@ibaned
Copy link
Contributor

ibaned commented Aug 8, 2018

I think this was fixed by #1718

@crtrott crtrott closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
2018 July
Development

No branches or pull requests
4 participants
@ibaned @pkestene @crtrott @ndellingwood