profiling label

[kyungjoo-kim]

random functor does not have labels.

N6Kokkos4Impl25fill_random_functor_rangeINS_4ViewIPPPNS_7complexIdEEJNS_10LayoutLeftENS_6OpenMPEEEENS_22Random_XorShift64_PoolIS9_EELi128ELi3ElEE (ParFor)           1.17556         2964         0.00040   0.818   0.573 

[dhollman]

Is this something we provide in general for internal Kokkos functors? What should our policy be on this?

[DavidPoliakoff]

@dhollman I'd like it if we had labels, it's fairly jarring for users to see stuff like this in their profiling outputs

[dhollman]

Yeah I agree. I was just thinking we should think this through and have some sort of convention, like surrounding the name with square brackets and/or prefixing the label with "Kokkos Internal" or something

[DavidPoliakoff]

I think [Kokkos Internal] KernelName would be a pretty idiomatic way to do this

[DavidPoliakoff]

@dhollman it gives some false positives, but match callExpr(callee(unresolvedLookupExpr(hasAnyDeclaration(namedDecl(matchesName("Kokkos::parallel_"))))),unless(anyOf(hasDescendant(stringLiteral()),hasAnyArgument(hasDescendant(declRefExpr(hasType(asString("const char*")))))))) gets us what we want.

I think the rule should be "if we're in Kokkos, unless we're in a forwarding layer which calls another Kokkos::parallel_* construct, calls to Kokkos::parallel_* must name their kernels." Does that sound like the semantics we want?

[dhollman]

Seems reasonable :-)

[dalg24]

@DavidPoliakoff will look into this