Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokkos Serial execution space is not tested with TeamPolicy. #207

Closed
kyungjoo-kim opened this issue Mar 9, 2016 · 3 comments
Closed

Kokkos Serial execution space is not tested with TeamPolicy. #207

kyungjoo-kim opened this issue Mar 9, 2016 · 3 comments

Comments

@kyungjoo-kim
Copy link
Contributor

Moved from Trilinos issue.

The following error comes from when I use Serial space (OpenMP space is okay). I think that the TeamPolicy does not work here. The Tpetra block crs matrix is already submitted to Christian's Trilinos repo and you can reproduce this error in CI testing.

/home/kyukim/Work/lib/trilinos/christian/packages/kokkos/core/src/Kokkos_Serial.hpp:672:9: error: no match for call to ‘(const Tpetra::Experimental::BlockCrsMatrix::localApplyBlockNoTrans(const Tpetra::Experimental::BlockMultiVector&, Tpetra::Experimental::BlockMultiVector&, Scalar, Scalar) [with Scalar = double; LO = int; GO = int; Node = Kokkos::Compat::KokkosDeviceWrapperNodeKokkos::Serial]::__lambda2) (Kokkos::Impl::ParallelFor::localApplyBlockNoTrans(const Tpetra::Experimental::BlockMultiVector&, Tpetra::Experimental::BlockMultiVector&, Scalar, Scalar) [with Scalar = double; LO = int; GO = int; Node = Kokkos::Compat::KokkosDeviceWrapperNodeKokkos::Serial]::__lambda2, Kokkos::TeamPolicyKokkos::Schedule<Kokkos::Dynamic, Kokkos::Serial>, Kokkos::Serial>::Member)’

@crtrott
Copy link
Member

crtrott commented Mar 10, 2016

The title of this issue is misleading. TeamPolicy is getting tested on a nightly basis with the serial backend. That said we need to figure out where this problem is coming from, and whether it is caused by a bug in Kokkos or an issue in the usage inside of (this experimental branch of) Tpetra.

@kyungjoo-kim
Copy link
Contributor Author

I did not read the error message carefully. The long template argument expansion make me tired of reading the message carefully. The error was in assignning an obejct to reference.
(Kokkos::Impl::SerialTeamMember to Kokkos::Impl::SerialTeamMember&). In the Kokkos unit tests, I see that member_type is passed with reference. Somehow it complains for this case.

@kyungjoo-kim
Copy link
Contributor Author

Oh..... I am sorry that I did not put "const" in the Tpetra. I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants