Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build only one version of Kokkos library for tests #213

Closed
gmackey opened this issue Mar 16, 2016 · 1 comment
Closed

Build only one version of Kokkos library for tests #213

gmackey opened this issue Mar 16, 2016 · 1 comment
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@gmackey
Copy link
Contributor

gmackey commented Mar 16, 2016

Currently, each of the testing subdirectories in the build directory has a separate copy of the Kokkos library compiled for it. Instead, there should be a single copy of the Kokkos library that is compiled and used by all of the testing subdirectories. This will reduce compile time for the tests.

The solution would need to work if doing a 'make build-test' from the top level directory or if doing a make in one of the subdirectories.

@gmackey gmackey added the Enhancement Improve existing capability; will potentially require voting label Mar 16, 2016
@hcedwar hcedwar added this to the Spring 2016 milestone Mar 17, 2016
@hcedwar hcedwar modified the milestones: Backlog, Spring 2016 Apr 27, 2016
@crtrott crtrott modified the milestones: END 2016, Backlog Dec 17, 2016
@crtrott crtrott assigned crtrott and unassigned gmackey Dec 17, 2016
@crtrott
Copy link
Member

crtrott commented Dec 17, 2016

Actually I fixed this a while ago in the way I think it should be fixed. We still build extra libraries for the unit and performance tests, but all examples etc. are build against an installed one). This guarantees that we still test inline builds but cut the total number of library builds from over 30 to 6. Also the library build on the unit and performance tests is only about 10% of the total build time for each of those tests. Total build time would only be reduced by <3% if we were to eliminate those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

3 participants