Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Kokkos config files and target files to correct folders #2162

Closed
jjwilke opened this issue Jun 1, 2019 · 3 comments
Closed

Install Kokkos config files and target files to correct folders #2162

jjwilke opened this issue Jun 1, 2019 · 3 comments
Assignees
@jjwilke
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
CMake Overhauls Milestone: Release 3.0

Comments

@jjwilke
Copy link

jjwilke commented Jun 1, 2019

Current installing to lib/CMake/Kokkos which accidentally works on a Mac. We should be installing to lib/cmake/Kokkos.

I don't see a reason for the 3.0 release keep the old location since we are making a somewhat clean break from old bad practices?
@jjwilke jjwilke mentioned this issue Jun 1, 2019
Closed
@crtrott crtrott added this to InProgress in CMake Overhauls Jun 5, 2019
@crtrott crtrott moved this from InProgress to Outstanding in CMake Overhauls Jun 5, 2019
@jjwilke jjwilke moved this from Outstanding to InProgress in CMake Overhauls Jun 5, 2019
@jjwilke
Copy link
Author

jjwilke commented Aug 6, 2019

I just install everything everywhere - both old locations and the CMake "correct" locations

@jjwilke jjwilke closed this as completed Aug 6, 2019
@jjwilke jjwilke moved this from InProgress to Done (merged into cmake-overhaul) in CMake Overhauls Aug 6, 2019
@mhoemmen
Copy link
Contributor

mhoemmen commented Aug 6, 2019

Is this done in Kokkos:master? The usual Kokkos policy is to leave issues open until they merge into master.

@jjwilke jjwilke reopened this Aug 7, 2019
@crtrott crtrott added this to To do in Milestone: Release 3.0 via automation Aug 23, 2019
@crtrott crtrott added this to the 3.0 Release milestone Aug 23, 2019
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Aug 23, 2019
@masterleinad
Copy link
Contributor

We only install to lib/cmake/Kokkos.

@masterleinad masterleinad moved this from To do to Done in Milestone: Release 3.0 Oct 1, 2019
@ndellingwood ndellingwood mentioned this issue Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjwilke jjwilke

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
No open projects
CMake Overhauls
Done (merged into cmake-overhaul)
Milestone: Release 3.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jjwilke @mhoemmen @masterleinad @crtrott @ndellingwood