-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop CMake option SEPARATE_TESTS #2266
Comments
No opinion. I don't actually know the history of this. |
Oh I didn't know that someone added that. I personally like the |
Fine by me. Then I will drop the option and always do a single executable. |
We may have had some weird link issues on some early experimental compilers before (like OpenMPTarget, or ROCm) but I think we can handle that via the standalone unit test during experimental development phase. And if they can't link our unit tests for one backend, there is no way they can link a Trilinos executable anyway ... |
I added this option (sorry I missed this conversation!). I mostly added this because tests were taking forever to recompile (because of Kokkos' "include everything everywhere" philosopy) and the only tests I was expecting to change behavior were the tasking tests. The |
I am trying to cleanup the logic of the test registration in
core/unit_tests
and I am tempted to drop theif(SEPARATE_TESTS)
. I personally like the finer granularity (option set toON
).Can you think of one reason one might want to have a single executable for the core unit tests?
cc: @crtrott @jjwilke
The text was updated successfully, but these errors were encountered: