Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inter-operatibility between View and DynRankView. #245

Closed
kyungjoo-kim opened this issue Apr 21, 2016 · 2 comments
Closed

Inter-operatibility between View and DynRankView. #245

kyungjoo-kim opened this issue Apr 21, 2016 · 2 comments
Assignees
Labels
Feature Request Create new capability; will potentially require voting
Milestone

Comments

@kyungjoo-kim
Copy link
Contributor

Now I mix a view with a dynrankview. Currently when I code

DynRankView a;
View b;
deep_copy(a, b);

this does not work. Can you provide assignment operator to chane one to another ?

DynRankView a;
View b;
DynRankView b_copy = b;
deep_copy(a, b_copy);

// or 

DynRankView a;
View b;
View a_copy = a;
deep_copy(a_copy, b);

// or 
deep_copy(a,b); 

Otherwise, I need to do

View b;
DynRankView<b::Layout,b::space> b_copy(a.data(), b.dimension(0), b.dimension(1));

This needs properties (like layout and space) and padding information. I don't think that the manual conversion is portable.

Any good idea ?

@crtrott
Copy link
Member

crtrott commented Apr 21, 2016

Yeah these things are missing features. I'll mark it as feature request.

@crtrott crtrott added the Feature Request Create new capability; will potentially require voting label Apr 21, 2016
@hcedwar hcedwar added this to the Backlog milestone Apr 27, 2016
@ndellingwood ndellingwood self-assigned this Jun 29, 2016
@ndellingwood ndellingwood modified the milestones: Summer 2016, Backlog Jun 29, 2016
@ndellingwood
Copy link
Contributor

The following interoperability features were added in #359
DynRankView redesigned to be its own View implementation
Added features:

Copy, Copy-assign View to DynRankView
deep_copy between Views and DynRankViews
subview function name now enabled (subdynrankview has same functionality)
Common method to request rank of a View and DynRankView: rank(user_view); This will eventually be replaced by a constexpr rank() in the View, but this will require coordination with packages and apps to avoid breaking their builds.

Important!
Before merging into Trilinos corresponding changes in Sacado must also be made as those in the attached patch file (as .txt)
sacado-mod-drvredesign-7.patch.txt
. Otherwise compatibility will break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Create new capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

4 participants