Segfault on Marvell from our finalization stack

[DavidPoliakoff]

Via a collaborator at Marvell (note that they're talking about this being on a Marvell platform, it won't reproduce on x86):

The GNU C++ Standard Library implements std::stack<T> in terms of std::deque<T>.

When compiling with clang/LLVM and using the GNU (GCC) C++ Standard Library (any recent version between GCC 7.3 and GCC 9.2), std::deque SEGV's during the unwinding of the atexit(3C) handlers at program termination. However, this bug is not observable when building with GCC.

The workaround is to replace std::stack<T> with std::list<T>.

As an added bonus, std::list<T> provides constant insertion and deletion time complexity, which translates to better run-time performance. As opposed to std::deque<T> which does not provide the same constant time complexity for inserts/removals, since std::deque<T> is implemented as a segmented array.