Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.kokkos incompatible with GNU make 4.3 #2870

Closed
pgrete opened this issue Mar 14, 2020 · 0 comments
Closed

Makefile.kokkos incompatible with GNU make 4.3 #2870

pgrete opened this issue Mar 14, 2020 · 0 comments
Labels
Enhancement Improve existing capability; will potentially require voting

Comments

@pgrete
Copy link
Contributor

pgrete commented Mar 14, 2020

From https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html

* WARNING: Backward-incompatibility!
  Number signs (#) appearing inside a macro reference or function invocation
  no longer introduce comments and should not be escaped with backslashes:
  thus a call such as:
    foo := $(shell echo '#')
  is legal.  Previously the number sign needed to be escaped, for example:
    foo := $(shell echo '\#')
  Now this latter will resolve to "\#".  If you want to write makefiles
  portable to both versions, assign the number sign to a variable:
    H := \#
    foo := $(shell echo '$H')

The resulting KokkosCore_config.h looks like

/* ---------------------------------------------
Makefile constructed configuration:
Sat 14 Mar 2020 09:44:44 AM CET
----------------------------------------------*/
\#if !defined(KOKKOS_MACROS_HPP) || defined(KOKKOS_CORE_CONFIG_H)
\#error "Do not include KokkosCore_config.h directly; include Kokkos_Macros.hpp instead."
\#else
\#define KOKKOS_CORE_CONFIG_H
\#endif

\#define KOKKOS_VERSION 30000
[...]

and doesn't work anymore.

@crtrott crtrott added this to the Tentative 3.3 Release milestone Mar 16, 2020
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Mar 16, 2020
@crtrott crtrott added this to To do in Milestone: Release 3.3 via automation Mar 16, 2020
Milestone: Release 3.3 automation moved this from To do to Done Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
No open projects
Development

No branches or pull requests

3 participants