Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building with nvcc and clang (or clang based XL) as host compiler: "Kokkos::atomic_fetch_min(volatile int *, int)" has already been defined #2903

Closed
ndellingwood opened this issue Mar 23, 2020 · 4 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@ndellingwood
Copy link
Contributor

Compilation error:

13:19:07 /home/jenkins/white/workspace/Kokkos_develop_white_cuda_92_xl_161_kepler/kokkos/core/src/impl/Kokkos_Atomic_MinMax.hpp(104): error: function "Kokkos::atomic_fetch_min(volatile int *, int)" has already been defined

Reproducer sample:

   #   Load modules:
         module load cmake/3.12.3 cuda/9.2.88 gcc/7.2.0 ibm/xl/16.1.1

   #   Use generate_makefile line below to call cmake which generates makefile for this build:

         <KOKKOS_PATH>/generate_makefile.bash --with-devices=Cuda,OpenMP --arch=Power8,Kepler37 --compiler=<KOKKOS_PATH>/bin/nvcc_wrapper --cxxflags="-O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized -ccbin xlc++" --cxxstandard="11" --ldflags="" --with-cuda --kokkos-path=<KOKKOS_PATH> --no-examples --with-options=enable_large_mem_tests
@ndellingwood ndellingwood added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Mar 23, 2020
@ndellingwood ndellingwood added this to the Tentative 3.1 Release milestone Mar 23, 2020
@crtrott
Copy link
Member

crtrott commented Mar 23, 2020

Fix is in #2904

@crtrott crtrott changed the title cuda/9.2+xl/16.1.1 build error in Cuda+OpenMP nightly test: "Kokkos::atomic_fetch_min(volatile int *, int)" has already been defined building with nvcc and clang (or clang based XL) as host compiler: "Kokkos::atomic_fetch_min(volatile int *, int)" has already been defined Mar 23, 2020
@ndellingwood
Copy link
Contributor Author

@crtrott the fix from #2904 now allows the failing build to compile, but the openmp.Random_XorShift64 test has now failed two consecutive rounds of testing (very unlikely to occur), should a new issue be opened for that?

https://jenkins-son.sandia.gov/job/Kokkos_develop_white_cuda_92_xl_161_kepler/809/display/redirect

https://jenkins-son.sandia.gov/job/Kokkos_develop_white_cuda_92_xl_161_kepler/810/display/redirect

@crtrott
Copy link
Member

crtrott commented Mar 24, 2020

Yeah I am looking into those as well as a segfault ...

@masterleinad
Copy link
Contributor

Hmm.. Can't reproduce on Summit.

@crtrott crtrott closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

3 participants