We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Kokkos_CopyViews.hpp at line 1909 we have fences before and after the copy:
Kokkos::fence(); if ((void*)dst.data() != (void*)src.data()) { Kokkos::Impl::DeepCopy<dst_memory_space, src_memory_space>( dst.data(), src.data(), nbytes); } Kokkos::fence();
But in Kokkos_DynRankView.hpp we have no fences for:
Line 1906: Kokkos::Impl::DeepCopy<dst_memory_space, src_memory_space>( dst.data(), src.data(), nbytes);
Line 1935: Kokkos::Impl::DeepCopy<dst_memory_space, src_memory_space>( dst.data(), src.data(), nbytes);
These should be added for consistency and possibly other spots as well.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In Kokkos_CopyViews.hpp at line 1909 we have fences before and after the copy:
But in Kokkos_DynRankView.hpp we have no fences for:
Line 1906:
Kokkos::Impl::DeepCopy<dst_memory_space, src_memory_space>(
dst.data(), src.data(), nbytes);
Line 1935:
Kokkos::Impl::DeepCopy<dst_memory_space, src_memory_space>(
dst.data(), src.data(), nbytes);
These should be added for consistency and possibly other spots as well.
The text was updated successfully, but these errors were encountered: