Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DynRankView fencing consistent #3014

Closed
MicheldeMessieres opened this issue May 6, 2020 · 0 comments
Closed

Make DynRankView fencing consistent #3014

MicheldeMessieres opened this issue May 6, 2020 · 0 comments

Comments

@MicheldeMessieres
Copy link
Contributor

In Kokkos_CopyViews.hpp at line 1909 we have fences before and after the copy:

Kokkos::fence();
if ((void*)dst.data() != (void*)src.data()) {
  Kokkos::Impl::DeepCopy<dst_memory_space, src_memory_space>(
      dst.data(), src.data(), nbytes);
}
Kokkos::fence();

But in Kokkos_DynRankView.hpp we have no fences for:

Line 1906:
Kokkos::Impl::DeepCopy<dst_memory_space, src_memory_space>(
dst.data(), src.data(), nbytes);

Line 1935:
Kokkos::Impl::DeepCopy<dst_memory_space, src_memory_space>(
dst.data(), src.data(), nbytes);

These should be added for consistency and possibly other spots as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants