Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing write fence for lock based atomics on CUDA #3038

Closed
crtrott opened this issue May 15, 2020 · 1 comment
Closed

Missing write fence for lock based atomics on CUDA #3038

crtrott opened this issue May 15, 2020 · 1 comment
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
Milestone: Release 3.2
Milestone
Tentative 3.2 Rel...

Comments

@crtrott
Copy link
Member

crtrott commented May 15, 2020

I wrote a new performance test for desul, and then added a correctness check to it. And Kokkos atomics weren't passing it for Complex
@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label May 15, 2020
@crtrott crtrott added this to the Tentative 3.2 Release milestone May 15, 2020
@crtrott crtrott self-assigned this May 15, 2020
@crtrott
Copy link
Member Author

crtrott commented Jul 23, 2020

the lock acquire and release needs to be sequenced with the actual data access.

@crtrott crtrott mentioned this issue Jul 23, 2020
Merged
@ndellingwood ndellingwood added this to Done in Milestone: Release 3.2 via automation Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
No open projects
Milestone: Release 3.2
  
Done
Milestone
Tentative 3.2 Release
Development

No branches or pull requests
2 participants
@crtrott @ndellingwood