Issue 2013: combined reducers #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
requested changes
May 21, 2020
dalg24
reviewed
May 21, 2020
|
Retest this please |
dalg24
reviewed
May 27, 2020
dalg24
reviewed
May 27, 2020
dhollman
force-pushed
the
issue-2013-combined-reducers
branch
from
811cac3
to
8c4bf57
Compare
|
@dalg24 any further changes needed? |
added 3 commits
June 29, 2020 17:24
Squashed 5 commits: [WIP] combined reducer and overloads implemented but not yet compiling [WIP] combined reducers fixes builds and runs with clang 10 and gcc 7 fleshed out comments a bit more, cosmetic changes tiny change to preempt future unused argument errors
Squash of multiple commits: - combined reducers working with custom reducer - C++11 constexpr fixes - Fixes for CUDA (functon markip and explicit default functions) - GCC 4.8 fix for noexcept markup
crtrott
force-pushed
the
issue-2013-combined-reducers
branch
from
f648a36
to
1b2843b
Compare
dalg24
approved these changes
Jun 30, 2020
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation that supports only combining of scalar references, for now