Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_allocated to all appropriate view like containers #3059

Merged
merged 23 commits into from
Jun 1, 2020

Conversation

jeffmiles63
Copy link
Contributor

Added is_allocated function to the following classes and unit tests:
Kokkos::View
Kokkos::DualView
Kokkos::DynRankView
Kokkos::DynamicView
Kokkos::Vector
Kokkos::BitSet
Kokkos::OffsetView
Kokkos::ScatterView
Kokkos::StaticCrsGraph
Kokkos::UnorderedMap
Kokkos::Array

Part of issue #3024

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #3059 into develop will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #3059     +/-   ##
=========================================
+ Coverage     82.6%   82.7%   +0.1%     
=========================================
  Files          122     122             
  Lines         8074    8126     +52     
=========================================
+ Hits          6673    6725     +52     
  Misses        1401    1401             
Flag Coverage Δ
#clang 81.5% <100.0%> (+<0.1%) ⬆️
#gcc 83.0% <100.0%> (+0.1%) ⬆️
Impacted Files Coverage Δ
containers/src/Kokkos_DynRankView.hpp 92.3% <ø> (ø)
core/src/Kokkos_Array.hpp 100.0% <ø> (ø)
containers/src/Kokkos_Bitset.hpp 92.8% <100.0%> (+0.1%) ⬆️
containers/src/Kokkos_DualView.hpp 77.4% <100.0%> (+0.3%) ⬆️
containers/src/Kokkos_DynamicView.hpp 88.8% <100.0%> (+1.1%) ⬆️
containers/src/Kokkos_OffsetView.hpp 95.6% <100.0%> (+0.1%) ⬆️
containers/src/Kokkos_ScatterView.hpp 91.7% <100.0%> (+0.4%) ⬆️
containers/src/Kokkos_StaticCrsGraph.hpp 96.5% <100.0%> (+0.2%) ⬆️
containers/src/Kokkos_UnorderedMap.hpp 97.6% <100.0%> (+<0.1%) ⬆️
containers/src/Kokkos_Vector.hpp 81.3% <100.0%> (+0.4%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e526f7e...6dd3b7f. Read the comment docs.

@dalg24
Copy link
Member

dalg24 commented May 27, 2020

I don't think we should add is_allocated to Kokkos::Array.

@crtrott
Copy link
Member

crtrott commented May 27, 2020

definitely not to Array.

@crtrott
Copy link
Member

crtrott commented May 28, 2020

Retest this please.

Copy link
Member

@crtrott crtrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffmiles63 can you add documentation (you can do it on the public wiki)

@crtrott crtrott merged commit 9885c19 into kokkos:develop Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants