Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemorySpace::allocate needs to have memory pool counting. #3064

Closed
crtrott opened this issue May 26, 2020 · 0 comments
Closed

MemorySpace::allocate needs to have memory pool counting. #3064

crtrott opened this issue May 26, 2020 · 0 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@crtrott
Copy link
Member

crtrott commented May 26, 2020

The lowest level public API for memory allocation doesn't tack allocations via profiling hooks.

  • Consolidate all memory tracking to MemorySpace::allocate and MemorySpace::deallocate
  • Pass the label in
  • DO NOT try to recover the label from the allocation since MemorySpace::allocate can allocate memory without adding our allocation header
  • allocate(size_t) and deallocate(void*, size_t) use empty label
  • add allocate(const std::string, size_t) and deallocate(const std::string, void*, size_t) which are also called by the no-label overloads.
  • if a label is passed to allocate it is technically a user error to not pass the same label to deallocate - though I guess a tool can recover, since the ptr has to match at least..
@crtrott crtrott added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Blocks Promotion Overview issue for release-blocking bugs labels Jun 1, 2020
@crtrott crtrott added InDevelop and removed Blocks Promotion Overview issue for release-blocking bugs labels Jun 22, 2020
@crtrott crtrott added this to To do in Milestone: Release 3.2 via automation Jun 22, 2020
@crtrott crtrott added this to the Tentative 3.2 Release milestone Jun 22, 2020
@crtrott crtrott moved this from To do to In progress in Milestone: Release 3.2 Jun 22, 2020
@crtrott crtrott moved this from In progress to Done in Milestone: Release 3.2 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
No open projects
Development

No branches or pull requests

3 participants