-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow naming of Views for initialization kernel #3070
Comments
Is there a reason why naming initialization kernels with the View's name shouldn't be default behavior? |
Yeah I think we can just in general attach the name of the view |
|
Exactly my thought
|
Sorry, I read only Christian's comment in my email. @mhoemmen , good point, there isn't, we should do that. Christian, if we do that, your labeling scheme is a good one |
Also what I meant is: no option for this, we just do it. |
@crtrott , I agree with that, unless somebody comes by the issue and makes a strong case otherwise. |
@cielling is seeing a nontrivial amount of time being spent in View initialization, and asked in the Slack whether those kernels could be named by the name of the View being initialized, rather than just
Kokkos::View:initialization
Personally I'm in favor of an environment variable/command line argument to allow that. I worry about the proliferation of such arguments, and have some desire to see it be a build time option, but this should be fine, and we should definitely implement it in some form
The text was updated successfully, but these errors were encountered: