Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow naming of Views for initialization kernel #3070

Closed
DavidPoliakoff opened this issue May 28, 2020 · 7 comments
Closed

Allow naming of Views for initialization kernel #3070

DavidPoliakoff opened this issue May 28, 2020 · 7 comments
Assignees
Labels
Feature Request Create new capability; will potentially require voting

Comments

@DavidPoliakoff
Copy link
Contributor

@cielling is seeing a nontrivial amount of time being spent in View initialization, and asked in the Slack whether those kernels could be named by the name of the View being initialized, rather than just Kokkos::View:initialization

Personally I'm in favor of an environment variable/command line argument to allow that. I worry about the proliferation of such arguments, and have some desire to see it be a build time option, but this should be fine, and we should definitely implement it in some form

@DavidPoliakoff DavidPoliakoff added the Feature Request Create new capability; will potentially require voting label May 28, 2020
@DavidPoliakoff DavidPoliakoff self-assigned this May 28, 2020
@mhoemmen
Copy link
Contributor

Is there a reason why naming initialization kernels with the View's name shouldn't be default behavior?

@crtrott
Copy link
Member

crtrott commented May 29, 2020

Yeah I think we can just in general attach the name of the view

@crtrott
Copy link
Member

crtrott commented May 29, 2020

Kokkos::View::initialization[VIEWLABEL] maybe?

@DavidPoliakoff
Copy link
Contributor Author

DavidPoliakoff commented May 29, 2020 via email

@DavidPoliakoff
Copy link
Contributor Author

Sorry, I read only Christian's comment in my email. @mhoemmen , good point, there isn't, we should do that. Christian, if we do that, your labeling scheme is a good one

@crtrott
Copy link
Member

crtrott commented Jun 1, 2020

Also what I meant is: no option for this, we just do it.

@DavidPoliakoff
Copy link
Contributor Author

@crtrott , I agree with that, unless somebody comes by the issue and makes a strong case otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Create new capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

5 participants