Change Enums in ScatterView to types #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Jun 3, 2020
| struct DefaultContribution; | ||
|
|
||
| #ifdef KOKKOS_ENABLE_SERIAL | ||
| template <> | ||
| struct DefaultDuplication<Kokkos::Serial> { | ||
| enum : int { value = Kokkos::Experimental::ScatterNonDuplicated }; | ||
| using duplication_type = Kokkos::Experimental::ScatterNonDuplicated; |
There was a problem hiding this comment.
I'm not sure I understand your question. Could you please clarify.
There was a problem hiding this comment.
I think duplication_tag is a better name, as it indicates what it is.
That leads to side questions:
- Should "Tag" be part of the name of the tag, as in
ScatterNonDuplicatedTag? (It seems like extra verbosity which doesn't really convey extra meaning, so I'm leaning against it.) - Should tag types have
explicitdefault constructors? When passed to functions, it disallows aggregate initialization{}syntax. I don't think it matters at all in this case, but we should have a consistent policy towards it.
|
|
Retest this please |
|
@jeffmiles63 build issues are related to c5e32b8#diff-90ccdebd1a5c5cce9dce2a2d6bfd4c74 that got merged in the meantime. |
jeffmiles63
force-pushed
the
fix-make-scatterview
branch
2 times, most recently
from
d48d581
to
3d8aac7
Compare
|
Can you squash your changes? |
apply clang format add / fix overrides of create_scatter_view Fix issue with HPX fix comments with ScatterValue fix compile error after rebasing change types to tags Fix issue with OpenMPTarget Fix formatting for openmp target fix compilation issues with scatter view and openmptarget
jeffmiles63
force-pushed
the
fix-make-scatterview
branch
from
8fc60fe
to
ac45b66
Compare
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
masterleinad
approved these changes
Jul 30, 2020
|
Retest this please. |
…lication::{duplication_tag -> type}
masterleinad
reviewed
Aug 5, 2020
masterleinad
reviewed
Aug 5, 2020
masterleinad
approved these changes
Aug 5, 2020
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
dalg24
force-pushed
the
fix-make-scatterview
branch
from
150de6d
to
a938b2f
Compare
This was referenced Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all of ScatterView and aggregate classes to use types instead of enum.
Update create_scatter_view to use types instead of enums
Add two additional create_scatter_view overloads that can derive the types:
create_scatter_view(OpType, Duplication, Contribution,View<RT, RP...> const& original_view)create_scatter_view(OpType,View<RT, RP...> const& original_view)Added/updated unit tests to match changes
Also cleaned up the documentation for ScatterValue classes
Part of issue #3024