Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HIPInternal::print_configuration #3080

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

masterleinad
Copy link
Contributor

Sample output:

macro  KOKKOS_ENABLE_HIP : defined
macro  HIP_VERSION = 303 = version 3.3
Kokkos::Experimental::HIP[ 0 ] Vega 20 version 3.0, Total Global Memory: 31.98 G, Shared Memory per Wavefront: 64 K
Kokkos::Experimental::HIP[ 1 ] Vega 20 version 3.0, Total Global Memory: 31.98 G, Shared Memory per Wavefront: 64 K
Kokkos::Experimental::HIP[ 2 ] Vega 20 version 3.0, Total Global Memory: 31.98 G, Shared Memory per Wavefront: 64 K
Kokkos::Experimental::HIP[ 3 ] Vega 20 version 3.0, Total Global Memory: 31.98 G, Shared Memory per Wavefront: 64 K
Selected: 0

@masterleinad
Copy link
Contributor Author

Retest this please.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be flushing the output stream.
I would replace std::endl -> '\n'


#if defined( KOKKOS_ENABLE_HIP )
s << "macro KOKKOS_ENABLE_HIP : defined" << std::endl ;
#if defined(KOKKOS_ENABLE_HIP)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels superfluous to check that the macro is defined. Wouldn't be there otherwise.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #3080 into develop will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3080   +/-   ##
=======================================
  Coverage     85.6%   85.7%           
=======================================
  Files          122     122           
  Lines        10391   10392    +1     
=======================================
+ Hits          8905    8906    +1     
  Misses        1486    1486           
Flag Coverage Δ
#clang 76.1% <ø> (ø)
#gcc 86.4% <ø> (+<0.1%) ⬆️
Impacted Files Coverage Δ
core/src/impl/Kokkos_TaskQueueCommon.hpp 85.8% <0.0%> (-0.9%) ⬇️
core/src/OpenMP/Kokkos_OpenMP_Task.hpp 98.7% <0.0%> (+<0.1%) ⬆️
containers/src/Kokkos_UnorderedMap.hpp 97.6% <0.0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605ab03...f4f6149. Read the comment docs.

@dalg24 dalg24 merged commit 9408538 into kokkos:develop Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants