-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified KOKKOS_FUNCTION
macros so that if clang-tidy is detected the behavior is modified
#3087
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this passes CI, I like the implementation
Add to whitelist |
Codecov Report
@@ Coverage Diff @@
## develop #3087 +/- ##
=========================================
- Coverage 85.7% 85.6% -0.1%
=========================================
Files 122 122
Lines 10392 10391 -1
=========================================
- Hits 8906 8905 -1
Misses 1486 1486
Continue to review full report at Codecov.
|
KOKKOS_FUNCTION
macros so that if clang-tidy is detected the behavior is modifiedKOKKOS_FUNCTION
macros so that if clang-tidy is detected the behavior is modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The purpose for this is to make it easier to detect if a function has been annotated with
KOKKOS_FUNCTION