Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified KOKKOS_FUNCTION macros so that if clang-tidy is detected the behavior is modified #3087

Merged
merged 3 commits into from
Jun 9, 2020

Conversation

calewis
Copy link

@calewis calewis commented Jun 9, 2020

The purpose for this is to make it easier to detect if a function has been annotated with KOKKOS_FUNCTION

@dalg24-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@calewis calewis requested review from dalg24 and dhollman and removed request for dalg24 June 9, 2020 17:08
Copy link
Contributor

@DavidPoliakoff DavidPoliakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this passes CI, I like the implementation

@dalg24
Copy link
Member

dalg24 commented Jun 9, 2020

Add to whitelist

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #3087 into develop will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #3087     +/-   ##
=========================================
- Coverage     85.7%   85.6%   -0.1%     
=========================================
  Files          122     122             
  Lines        10392   10391      -1     
=========================================
- Hits          8906    8905      -1     
  Misses        1486    1486             
Flag Coverage Δ
#clang 76.1% <ø> (+<0.1%) ⬆️
#gcc 86.4% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
containers/src/Kokkos_UnorderedMap.hpp 97.1% <0.0%> (-0.5%) ⬇️
core/src/OpenMP/Kokkos_OpenMP_Task.hpp 98.7% <0.0%> (-0.1%) ⬇️
core/src/impl/Kokkos_TaskQueueCommon.hpp 86.7% <0.0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9408538...9dd343d. Read the comment docs.

@masterleinad masterleinad changed the title ModifieModified KOKKOS_FUNCTION macros so that if clang-tidy is detected the behavior is modified Modified KOKKOS_FUNCTION macros so that if clang-tidy is detected the behavior is modified Jun 9, 2020
Copy link

@dhollman dhollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalg24 dalg24 merged commit b696f52 into kokkos:develop Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants