Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subview View layout determination #309

Closed
hcedwar opened this issue May 31, 2016 · 1 comment
Closed

subview View layout determination #309

hcedwar opened this issue May 31, 2016 · 1 comment
Assignees
@hcedwar @crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
Fall 2016

Comments

@hcedwar
Copy link
Contributor

hcedwar commented May 31, 2016

impl/KokkosExp_ViewMapping.hpp:2749-2761 subview View layout determination logic is flawed. To preserve the layout for a rank 2 View layout_left the first two subview arguments must be ranges. To preserve the layout for a rank 2 View layout_right the last two subview arguments must be ranges.
@hcedwar hcedwar added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label May 31, 2016
@hcedwar hcedwar added this to the Summer 2016 milestone May 31, 2016
@hcedwar hcedwar self-assigned this May 31, 2016
@hcedwar hcedwar modified the milestones: Backlog, Summer 2016 Jul 20, 2016
@crtrott crtrott self-assigned this Sep 19, 2016
@crtrott
Copy link
Member

crtrott commented Sep 19, 2016

Ok I believe this actually works correct now. Not sure if there ever was a bug. Here is the testcode:

main.txt

@crtrott crtrott closed this as completed Sep 19, 2016
@crtrott crtrott modified the milestones: Fall 2016, Backlog Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcedwar hcedwar

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
Fall 2016
Development

No branches or pull requests
2 participants
@hcedwar @crtrott