Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send --cudart to nvcc instead of host compiler #3092

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

streichler
Copy link

nvcc supports --cudart {none|shared|static}, while host compilers have no idea what to do with it...

@dalg24-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@dalg24
Copy link
Member

dalg24 commented Jun 11, 2020

OK to test

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #3092 into develop will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #3092     +/-   ##
=========================================
- Coverage     85.7%   85.6%   -0.1%     
=========================================
  Files          122     122             
  Lines        10392   10391      -1     
=========================================
- Hits          8906    8904      -2     
- Misses        1486    1487      +1     
Flag Coverage Δ
#clang 76.1% <ø> (+<0.1%) ⬆️
#gcc 86.4% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
core/src/impl/Kokkos_HostThreadTeam.cpp 96.0% <0.0%> (-0.8%) ⬇️
containers/src/Kokkos_UnorderedMap.hpp 97.1% <0.0%> (-0.5%) ⬇️
core/src/OpenMP/Kokkos_OpenMP_Task.hpp 98.7% <0.0%> (-0.1%) ⬇️
core/src/impl/Kokkos_TaskQueueCommon.hpp 86.7% <0.0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f4004...12c6570. Read the comment docs.

@crtrott crtrott merged commit 01039c0 into kokkos:develop Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants