Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KOKKKOS_ENABLE_PROFILING Option #3095

Closed
crtrott opened this issue Jun 11, 2020 · 3 comments
Closed

Remove KOKKKOS_ENABLE_PROFILING Option #3095

crtrott opened this issue Jun 11, 2020 · 3 comments
Assignees
@DavidPoliakoff
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
Milestone: Release 3.2
Milestone
Tentative 3.2 Rel...

Comments

@crtrott
Copy link
Member

crtrott commented Jun 11, 2020

We will remove that option. The dependency on libdl will be explicitly managed, and if no libdl is available the dynamic loading of a profiling library will not be possible. The new explicit API to fill the tools hooks will always exist.
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Jun 11, 2020
@crtrott crtrott added this to the Tentative 3.2 Release milestone Jun 11, 2020
@crtrott
Copy link
Member Author

crtrott commented Jun 11, 2020

We already have Kokkos_ENABLE_LIBDL as a public option. That one will determine whether the dynamic loading of a tool is possible via pointing to a shared library with the environement variable.

@DavidPoliakoff
Copy link
Contributor

I'm in favor of it

@DavidPoliakoff DavidPoliakoff mentioned this issue Jun 18, 2020
Merged
@DavidPoliakoff
Copy link
Contributor

Done in #3115

@DavidPoliakoff DavidPoliakoff added this to Done in Milestone: Release 3.2 via automation Jul 6, 2020
@DavidPoliakoff DavidPoliakoff reopened this Jul 6, 2020
Milestone: Release 3.2 automation moved this from Done to In progress Jul 6, 2020
Milestone: Release 3.2 automation moved this from In progress to Done Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidPoliakoff DavidPoliakoff

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
No open projects
Milestone: Release 3.2
  
Done
Milestone
Tentative 3.2 Release
Development

No branches or pull requests
3 participants
@DavidPoliakoff @crtrott @ndellingwood