WorkGraphPolicy for HIP #3096
Merged
WorkGraphPolicy for HIP #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
enable_hip_workgraphpolicy
branch
from
5f3bd35
to
2512066
Compare
Rombur
reviewed
Jun 11, 2020
|
|
||
| public: | ||
| __device__ inline void operator()() const noexcept { | ||
| if (0 == (threadIdx.y % 16)) { |
There was a problem hiding this comment.
threadIdx.y -> hipThreadIdx_y and what's 16?
Codecov Report
@@ Coverage Diff @@
## develop #3096 +/- ##
=========================================
- Coverage 85.7% 85.7% -0.1%
=========================================
Files 122 122
Lines 10385 10385
=========================================
- Hits 8906 8905 -1
- Misses 1479 1480 +1
Continue to review full report at Codecov.
|
dalg24
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less verbatim copied from the
CUDAimplementation.The test was failing with HIP 3.3 but works with 3.5.