Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require HIP 3.5.0 or higher #3099

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Conversation

masterleinad
Copy link
Contributor

We decided to remove the check for hcc already which is what this pull request does.
Additionally, we also check for the HIP version to be at least 3.5.0.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020

Codecov Report

Merging #3099 into develop will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #3099     +/-   ##
=========================================
- Coverage     85.7%   85.7%   -0.1%     
=========================================
  Files          122     122             
  Lines        10385   10385             
=========================================
- Hits          8906    8905      -1     
- Misses        1479    1480      +1     
Flag Coverage Δ
#clang 76.2% <ø> (+<0.1%) ⬆️
#gcc 86.4% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
containers/src/Kokkos_UnorderedMap.hpp 97.1% <0.0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48b709...06009ed. Read the comment docs.

@dalg24 dalg24 merged commit 12adcba into kokkos:develop Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants