Add CUDA Ampere configuration support #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidPoliakoff
approved these changes
Jun 22, 2020
dalg24
requested changes
Jun 22, 2020
| + $(KOKKOS_INTERNAL_USE_ARCH_MAXWELL52) \ | ||
| + $(KOKKOS_INTERNAL_USE_ARCH_MAXWELL53)) | ||
| KOKKOS_INTERNAL_USE_ARCH_NVIDIA := $(shell expr $(KOKKOS_INTERNAL_USE_ARCH_KEPLER35) \ | ||
| + $(KOKKOS_INTERNAL_USE_ARCH_MAXWELL50)) |
There was a problem hiding this comment.
the conditional was redundant. You only enter this if none of the above were set, and the only ones to check for at this pointer were general Maxwell/Kepler which set Maxwell50 and Kepler35 respectively. So you only need to some up those two at this point.
masterleinad
previously requested changes
Jun 22, 2020
Makefile.kokkos
Outdated
| + $(KOKKOS_INTERNAL_USE_ARCH_VOLTA70) \ | ||
| + $(KOKKOS_INTERNAL_USE_ARCH_VOLTA72) \ | ||
| + $(KOKKOS_INTERNAL_USE_ARCH_TURING75) \ | ||
| + $(KOKKOS_INTERNAL_USE_ARCH_AMPERE80)) |
There was a problem hiding this comment.
Suggested change
| + $(KOKKOS_INTERNAL_USE_ARCH_AMPERE80)) | |
| + $(KOKKOS_INTERNAL_USE_ARCH_AMPERE80)) |
There was a problem hiding this comment.
there were some tabs. fixed.
cmake/kokkos_arch.cmake
Outdated
| @@ -79,6 +80,10 @@ IF (KOKKOS_ENABLE_CUDA) | |||
| IF (KOKKOS_ARCH_VOLTA70 OR KOKKOS_ARCH_VOLTA72) | |||
| SET(KOKKOS_ARCH_VOLTA ON) | |||
| ENDIF() | |||
|
|
|||
| IF (KOKKOS_ARCH_AMPERE80) | |||
| SET(KOKKOS_ARCH_AMPERE ON) | |||
There was a problem hiding this comment.
Suggested change
| SET(KOKKOS_ARCH_AMPERE ON) | |
| SET(KOKKOS_ARCH_AMPERE ON) |
|
Added the cuda_compute_capability.cc option. |
dalg24
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.