Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak when using CUDA stream #3167

Closed
Rombur opened this issue Jul 8, 2020 · 1 comment
Closed

Memory leak when using CUDA stream #3167

Rombur opened this issue Jul 8, 2020 · 1 comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@Rombur
Copy link
Member

Rombur commented Jul 8, 2020

We currently have a memory leak when using CUDA stream here. We cannot simply delete the object by the constructor because we pass it by copy everywhere. When we don't use a stream, we have a singleton that is correctly cleaned up in Kokkos::finalize().
@masterleinad masterleinad mentioned this issue Jul 8, 2020
Merged
@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Jul 8, 2020
@crtrott
Copy link
Member

crtrott commented Jul 8, 2020

Make it a shared pointer to the instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Rombur @masterleinad @crtrott @ndellingwood