Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RangePolicy and TeamPolicy assignable #3196

Merged
merged 7 commits into from
Jul 23, 2020

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Jul 17, 2020

Fix #3192

NOTE Not sure what happened with clang-format in the unit test

@crtrott
Copy link
Member

crtrott commented Jul 19, 2020

what I don't get is how this slipped through … That doesn't make ANY sense whatesoever. Nobody ever tried to assign a policy or make it a member of a class or something like that????

I mean this is ridiculous that this doesn't compile.

    Kokkos::RangePolicy<> pr1, pr2;
    pr1 = pr2;
    pr1 = Kokkos::RangePolicy<>(0,N);
    pr2 = pr1;
    Kokkos::TeamPolicy<> pt1, pt2;
    pt1 = pt2;
    pt1 = Kokkos::TeamPolicy<>(0,N);
    pt2 = pt1;

Also TeamPolicy doesn't have a default constructor???? OMG.

@dalg24
Copy link
Member Author

dalg24 commented Jul 20, 2020

So should we make them semiregular?

@dalg24
Copy link
Member Author

dalg24 commented Jul 21, 2020

FYI, in the current HEAD of the develop branch and in all releases of the 3.X series, TeamPolicy is both copy and move assignable.

@dalg24
Copy link
Member Author

dalg24 commented Jul 22, 2020

We decided we would make them semiregular.

@dalg24
Copy link
Member Author

dalg24 commented Jul 22, 2020

This is ready.
Use https://github.com/kokkos/kokkos/pull/3196/files/86b9ea346f98df44833f75d18464abe3a30d9bf6
to filter out the clang-format changes

@crtrott crtrott merged commit a1b036c into kokkos:develop Jul 23, 2020
@dalg24 dalg24 deleted the policy_assignable branch July 24, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants