-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RangePolicy and TeamPolicy assignable #3196
Conversation
5ac3de5
to
abdb281
Compare
what I don't get is how this slipped through … That doesn't make ANY sense whatesoever. Nobody ever tried to assign a policy or make it a member of a class or something like that???? I mean this is ridiculous that this doesn't compile. Kokkos::RangePolicy<> pr1, pr2;
pr1 = pr2;
pr1 = Kokkos::RangePolicy<>(0,N);
pr2 = pr1;
Kokkos::TeamPolicy<> pt1, pt2;
pt1 = pt2;
pt1 = Kokkos::TeamPolicy<>(0,N);
pt2 = pt1; Also TeamPolicy doesn't have a default constructor???? OMG. |
So should we make them semiregular? |
FYI, in the current HEAD of the develop branch and in all releases of the 3.X series, |
We decided we would make them semiregular. |
Applied to all template partial specializations (for all execution spaces)
That way the compiler will generate copy and move assignment operators.
abdb281
to
a771ac9
Compare
This is ready. |
Fix #3192
NOTE Not sure what happened with clang-format in the unit test