Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for Kokkos to provide Kokkos::atomic_fetch_max and atomic_fetch_min #336

Closed
mrtupek opened this issue Jun 27, 2016 · 4 comments
Assignees
Labels
Feature Request Create new capability; will potentially require voting
Milestone

Comments

@mrtupek
Copy link

mrtupek commented Jun 27, 2016

We can use the Kokkos::Impl::atomic_fetch_oper(...) mechanism, but this is in the Impl namespace and having hard-coded max and min atomics seems like it would be useful to the community.

@ndellingwood ndellingwood added the Feature Request Create new capability; will potentially require voting label Jun 29, 2016
@ndellingwood ndellingwood added this to the Summer 2016 milestone Jun 29, 2016
@ndellingwood ndellingwood self-assigned this Jun 29, 2016
@ndellingwood
Copy link
Contributor

Add necessary unit tests, along with other missing tests (e.g. binary operations); see #341 as well.

@hcedwar
Copy link
Contributor

hcedwar commented Jul 20, 2016

Note: no corresponding functionality in C++11 atomics

@crtrott
Copy link
Member

crtrott commented Jul 21, 2016

Yeah, but that doesn't mean we shouldn't support it. I rather have us supporting this, than each team doing its own implementation.

@ndellingwood
Copy link
Contributor

In develop branch

@crtrott crtrott closed this as completed Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Create new capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

4 participants