Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvcc_wrapper -> $(NVCC_WRAPPER) #42

Closed
pkestene opened this issue Jul 3, 2015 · 1 comment
Closed

nvcc_wrapper -> $(NVCC_WRAPPER) #42

pkestene opened this issue Jul 3, 2015 · 1 comment

Comments

@pkestene
Copy link
Contributor

pkestene commented Jul 3, 2015

Hi,

this is a minor thing, but it could be useful to define NVCC_WRAPPER in the top level Makefile.kokkos
NVCC_WRAPPER := $(KOKKOS_PATH)/config/nvcc_wrapper
for people not accustomed to trilinos build, they may not be aware of nvcc_wrapper.

I also think that nvcc_wrapper could be installed in $(PREFIX)/bin

In case it is useful, i did the modification in my repo.

Some examples are missing a Makefile; I added one so that they still build when KOKKOS_PATH points to the install location (where is the customized Makefile.kokkos) instead of top-level kokkos source path.

best regards,
Pierre.

@crtrott
Copy link
Member

crtrott commented Sep 5, 2015

I did merge the changes into the develop branch.

@crtrott crtrott closed this as completed Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants