Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.6.00 installs the file include/CMakeLists.txt #4983

Closed
yurivict opened this issue Apr 27, 2022 · 9 comments
Closed

3.6.00 installs the file include/CMakeLists.txt #4983

yurivict opened this issue Apr 27, 2022 · 9 comments
Assignees
@dalg24
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) InDevelop Enhancement, fix, etc. has been merged into the develop branch;

Comments

@yurivict
Copy link

Project's CMakeLists.txt should never be installed.
@dalg24
Copy link
Member

dalg24 commented Apr 27, 2022

I was able to reproduce. The issue is also in develop

├── bin
│   ├── hpcbind
│   ├── kokkos_launch_compiler
│   └── nvcc_wrapper
├── include
│   ├── CMakeLists.txt
│   ├── Cuda

Release 3.5 did not have it.

@dalg24
Copy link
Member

dalg24 commented Apr 27, 2022 •
edited
Loading

It is the Desul CMakeLists.txt core/src/CMakeLists.txt

@dalg24 dalg24 self-assigned this Apr 27, 2022
@dalg24
Copy link
Member

dalg24 commented Apr 27, 2022 •
edited
Loading

It was introduced in #4714 ... which was attempting to fix yet another issue you reported :)

@dalg24
Copy link
Member

dalg24 commented Apr 27, 2022

It is worse than that we were installing .cpp files too...

@dalg24 dalg24 mentioned this issue Apr 27, 2022
Merged
@dalg24 dalg24 added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Apr 27, 2022
@masterleinad masterleinad added the InDevelop Enhancement, fix, etc. has been merged into the develop branch; label Apr 29, 2022
@carlosal1015
Copy link

I can confirm too in Arch Linux.

@dalg24
Copy link
Member

dalg24 commented Apr 30, 2022

This is fixed in develop. We will cherry-pick it a the 3.6.01 patch release version.

@PhilMiller
Copy link
Contributor

Fix released in 3.6.01

@yurivict
Copy link
Author

But there is no 3.6.01 tag.

@PhilMiller
Copy link
Contributor

There is now. The release was in process when I was going down the list of issues to be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalg24 dalg24

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) InDevelop Enhancement, fix, etc. has been merged into the develop branch;
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@PhilMiller @yurivict @dalg24 @masterleinad @carlosal1015 @ajpowelsnl