Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kokkos Tests are Not Run using Compiler Optimization #501

Closed
nmhamster opened this issue Oct 24, 2016 · 5 comments
Closed

Kokkos Tests are Not Run using Compiler Optimization #501

nmhamster opened this issue Oct 24, 2016 · 5 comments
Assignees
@crtrott
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
END 2016

Comments

@nmhamster
Copy link
Contributor

Running some Kokkos tests across various platforms and I'm not seeing many of them issue even basic -O3 style optimization requests. We probably should be testing -O2 and -O3 as a way of checking we do not have subtle bugs in our codes. Seems to be most users switch between these two options in production environments.
@nmhamster nmhamster added the Feature Request Create new capability; will potentially require voting label Oct 24, 2016
@nmhamster nmhamster added this to the Fall 2016 milestone Oct 24, 2016
@nmhamster
Copy link
Contributor Author

OK, its early in the morning and I am not full of caffeine yet. -O3 is present but should we or could we test with -O2 as well? I am conscious on some platforms like POWER we may want to test with -O4 and -O5 as well (XL and PGI).

@crtrott
Copy link
Member

crtrott commented Oct 24, 2016

I think you can simply override the cxxflags with --cxxflags.

@crtrott
Copy link
Member

crtrott commented Oct 26, 2016

So do we have an actual issue or not? Is your suggestion just to add more tests some of them using -O2?

@hcedwar hcedwar added Question For Kokkos internal and external contributors and users and removed Feature Request Create new capability; will potentially require voting labels Nov 1, 2016
@hcedwar hcedwar modified the milestones: END 2016, Fall 2016 Nov 1, 2016
@hcedwar hcedwar added the Enhancement Improve existing capability; will potentially require voting label Dec 7, 2016
@hcedwar
Copy link
Contributor

hcedwar commented Dec 7, 2016

Add a small number of configurations in integration and nightly. Will have to monitor total resource consumption for testing.

@crtrott crtrott added InDevelop and removed Question For Kokkos internal and external contributors and users labels Dec 12, 2016
@crtrott
Copy link
Member

crtrott commented Dec 12, 2016

The mechanism is added, can put the jobs up in Jenkins now.

@crtrott crtrott closed this as completed Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
END 2016
Development

No branches or pull requests
3 participants
@hcedwar @nmhamster @crtrott