Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninclude source files for specific configurations to prevent link warning. #701

Closed
gmackey opened this issue Mar 22, 2017 · 2 comments
Closed
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@gmackey
Copy link
Contributor

gmackey commented Mar 22, 2017

There are three possible configuration that generate warnings about object files with no symbols when linking the kokkos library file. The errors are because all of the code in the source files is commented out due to defines not being defined. The configurations and files that need to be removed from the build are:

  1. When the Serial device is not enabled.
    • core/src/impl/Kokkos_Serial.cpp
    • core/src/impl/Kokkos_Serial_Task.cpp
  2. When profiling is disabled.
    • core/src/impl/Kokkos_Profiling_Interface.cpp
  3. When memkind is turned off.
    • core/src/impl/Kokkos_HBWSpace.cpp

The fix is to remove the offending files from the compile when it is one of the three configurations.

@gmackey gmackey added the Enhancement Improve existing capability; will potentially require voting label Mar 22, 2017
@gmackey gmackey added this to the 2017-April-end milestone Mar 22, 2017
@gmackey gmackey self-assigned this Mar 22, 2017
@gmackey
Copy link
Contributor Author

gmackey commented Mar 22, 2017

This fix is included in my cmake branch and will be pulled in with that branch.

@gmackey
Copy link
Contributor Author

gmackey commented Mar 22, 2017

The fix is in both Makefile.kokkos and in the pure CMake build.

@crtrott crtrott modified the milestones: 2017-April-end, 2017-June-end Apr 26, 2017
@crtrott crtrott closed this as completed May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

2 participants