Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for AppleClang as compiler distinct from check for Clang. #705

Closed
gmackey opened this issue Mar 22, 2017 · 1 comment
Closed

Add check for AppleClang as compiler distinct from check for Clang. #705

gmackey opened this issue Mar 22, 2017 · 1 comment
Assignees
@gmackey
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2017-July-end

Comments

@gmackey
Copy link
Contributor

gmackey commented Mar 22, 2017

Currently, AppleClang is detected as clang in Makefile.kokkos. In some cases the build needs to behave differently for Clang and AppleClang. Add in AppleClang as a distinct compiler from Clang in the compiler checks.
@gmackey gmackey added the Enhancement Improve existing capability; will potentially require voting label Mar 22, 2017
@gmackey gmackey added this to the 2017-April-end milestone Mar 22, 2017
@gmackey gmackey self-assigned this Mar 22, 2017
@gmackey
Copy link
Contributor Author

gmackey commented Mar 22, 2017

The fix is in my cmake branch and will be pulled in with it.

@gmackey gmackey mentioned this issue Mar 29, 2017
Closed
@crtrott crtrott modified the milestones: 2017-April-end, 2017-June-end Apr 26, 2017
@crtrott crtrott closed this as completed May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmackey gmackey

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2017-July-end
Development

No branches or pull requests
2 participants
@crtrott @gmackey