Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get wrong results for compiler checks in Makefile on OS X. #706

Closed
gmackey opened this issue Mar 22, 2017 · 2 comments
Closed

Get wrong results for compiler checks in Makefile on OS X. #706

gmackey opened this issue Mar 22, 2017 · 2 comments
Assignees
@dsunder
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
2017-July-end

Comments

@gmackey
Copy link
Contributor

gmackey commented Mar 22, 2017

The shell calls to check the compilers and a couple of other shell calls get wrong results on OS X. This is because of leading white space some of the shell commands generate on OS X. The fix is to add the strip command to the offending commands.
@gmackey gmackey added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Mar 22, 2017
@gmackey gmackey added this to the 2017-April-end milestone Mar 22, 2017
@gmackey gmackey self-assigned this Mar 22, 2017
@gmackey
Copy link
Contributor Author

gmackey commented Mar 22, 2017

The fix is in my CMake branch and will be pulled in with it.

@crtrott
Copy link
Member

crtrott commented Mar 22, 2017

I thought we fixed that on develop by adding the strip thing.

@gmackey gmackey mentioned this issue Mar 29, 2017
Closed
@crtrott crtrott modified the milestones: 2017-April-end, 2017-June-end Apr 26, 2017
@hcedwar hcedwar assigned dsunder and unassigned gmackey Apr 26, 2017
@crtrott crtrott closed this as completed May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsunder dsunder

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
2017-July-end
Development

No branches or pull requests
4 participants
@ibaned @dsunder @crtrott @gmackey