Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error copying dynamic view on copy of memory pool #773

Closed
bathmatt opened this issue May 4, 2017 · 2 comments
Closed

Error copying dynamic view on copy of memory pool #773

bathmatt opened this issue May 4, 2017 · 2 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@bathmatt
Copy link

bathmatt commented May 4, 2017

Question,
I assume you don't need to do anything special to copy dynamic views around? I have a class that has a dynamic view and a memory pool and I'm getting an error. Here is the traceback. Any ideas? I've ran this through valgrind and that changes the error to a big allocation. GUessing memory error, not sure where to look

#0  0x00007ffff56fdd94 in opal_memory_ptmalloc2_free () from /home/projects/x86-64-haswell-nvidia/openmpi/1.10.0/gcc/4.8.4/cuda/7.5.18/lib/libopen-pal.so.13
#1  0x00000000072d440f in Kokkos::HostSpace::deallocate (this=0xae44934, arg_alloc_ptr=0x7fff9b9ef080, arg_alloc_size=16777352)
    at /home/jenkins/workspace/Drekar-shiller-gnu-debug-openmp/Trilinos/packages/kokkos/core/src/impl/Kokkos_HostSpace.cpp:314
#2  0x00000000072d4551 in Kokkos::Impl::SharedAllocationRecord<Kokkos::HostSpace, void>::~SharedAllocationRecord (this=0xae44900, __in_chrg=<optimized out>)
    at /home/jenkins/workspace/Drekar-shiller-gnu-debug-openmp/Trilinos/packages/kokkos/core/src/impl/Kokkos_HostSpace.cpp:372
#3  0x0000000003e71d60 in Kokkos::Impl::SharedAllocationRecord<Kokkos::HostSpace, Kokkos::Experimental::DynamicView<long*>::Destroy>::~SharedAllocationRecord (this=0xae44900, __in_chrg=<optimized out>)
    at /home/projects/empire/install-for-drekar/GNU-DEBUG-OPENMP/include/impl/Kokkos_SharedAlloc.hpp:203
#4  0x0000000003e6076d in Kokkos::Impl::(anonymous namespace)::deallocate<Kokkos::HostSpace, Kokkos::Experimental::DynamicView<long*>::Destroy> (record_ptr=0xae44900)
    at /home/projects/empire/install-for-drekar/GNU-DEBUG-OPENMP/include/impl/Kokkos_SharedAlloc.hpp:187
#5  0x00000000072d6bf6 in Kokkos::Impl::SharedAllocationRecord<void, void>::decrement (arg_record=0xae44900) at /home/jenkins/workspace/Drekar-shiller-gnu-debug-openmp/Trilinos/packages/kokkos/core/src/impl/Kokkos_SharedAlloc.cpp:260
#6  0x0000000003e08490 in Kokkos::Impl::SharedAllocationTracker::operator= (rhs=..., this=0xae3a9d8) at /home/projects/empire/install-for-drekar/GNU-DEBUG-OPENMP/include/impl/Kokkos_SharedAlloc.hpp:371
#7  Kokkos::Experimental::DynamicView<long*>::operator= (this=0xae3a758) at /home/projects/empire/install-for-drekar/GNU-DEBUG-OPENMP/include/Kokkos_DynamicView.hpp:59
#8  0x0000000003e087ad in PIC::ParticleContainer::operator= (this=0xae3a328) at /home/mbetten/Trilinos/mini-PIC/src/PIC/ParticleContainer.hpp:20
#9  0x0000000003e138b4 in PIC::ParticleMove<PIC::PICMeshInteractionDirectBasis<PIC::MeshTraits<shards::Quadrilateral<4u>, 1> > >::weightCharge (this=0xae3a160) at /home/mbetten/Trilinos/mini-PIC/src/PIC/ParticleMove_impl.hpp:143
#10 0x0000000003d234ca in PIC::ParticleLists::weight_charge (this=0xae0d6d0) at /home/mbetten/Trilinos/mini-PIC/src/PIC/ParticleLists.cpp:122
#11 0x0000000003bcf477 in main (argc=2, argv=0x7fffffffaaa8) at /home/mbetten/Trilinos/mini-PIC/src/main.cpp:424

@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label May 4, 2017
@hcedwar
Copy link
Contributor

hcedwar commented May 4, 2017

@bathmatt
I assume that this in current kokkos/master (a.k.a., trilinos/kokkos) ?
The memory pool has had a complete overhaul and DynamicView in kokkos/develop holds onto its (reference-counted) supporting memory pool. This should address the bug you logged.
Just need to promote the current kokkos/develop to kokkos/master, and trilinos/kokkos.

@bathmatt
Copy link
Author

bathmatt commented May 5, 2017

trilinos/develop
How long until you promote to trilinos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

4 participants