Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokkos CUDA failes to compile with OMPI_CXX and MPICH_CXX wrappers #776

Closed
stanmoore1 opened this issue May 5, 2017 · 4 comments
Closed
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone

Comments

@stanmoore1
Copy link
Contributor

LAMMPS uses the OMPI_CXX and MPICH_CXX wrappers, see below. However, this functionality was broken due to recent changes in Makefile.kokkos.

export OMPI_CXX = $(KOKKOS_PATH)/config/nvcc_wrapper
CC =            mpicxx

See PR #775 for a fix.

@stanmoore1
Copy link
Contributor Author

The issue is that when using OMPI_CXX the nvcc compiler isn't found, and I get errors like:

g++: error: =sm_35: No such file or directory

@stanmoore1
Copy link
Contributor Author

This was broken by b586204.

@crtrott
Copy link
Member

crtrott commented May 8, 2017

We triaged the problem. There is a real issue with the root cause being that you can't seem to be able to set environment variables for commands run in the shell inside of Make. This means if you try to set OMPI_CXX inside of the Makefile it will be honored for the actual compilation, but some of our "What compiler I am using" logic doesn't see that setting. The associated pull request works around the issue in a sane way for now, but we need to be aware that it doesn't fix the root issue.

@crtrott crtrott self-assigned this May 8, 2017
@ibaned ibaned added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Jun 6, 2017
@ibaned ibaned added this to the 2017-June-end milestone Jun 14, 2017
@ibaned ibaned assigned dsunder and unassigned crtrott Jun 14, 2017
@nmhamster
Copy link
Contributor

@dsunder - I found this on the GNU make documentation. I think it may be useful for you: https://www.gnu.org/software/make/manual/make.html#Execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

6 participants